kbendick commented on a change in pull request #3460:
URL: https://github.com/apache/iceberg/pull/3460#discussion_r742301887
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java
##########
@@ -49,8 +49,8 @@ public TestSelect(String catalogName, String implementation,
Map<String, String>
@Before
public void createTables() {
- sql("CREATE TABLE %s (id bigint, data string, float float) USING iceberg",
tableName);
- sql("INSERT INTO %s VALUES (1, 'a', 1.0), (2, 'b', 2.0), (3, 'c',
float('NaN'))", tableName);
+ sql("CREATE TABLE %s (id bigint, data string, float float, binary binary)
USING iceberg", tableName);
+ sql("INSERT INTO %s VALUES (1, 'a', 1.0, X''), (2, 'b', 2.0, X'11'), (3,
'c', float('NaN'), X'1111')", tableName);
Review comment:
I'd also add that repurposing existing test cases makes it harder for
people who maintain forks and might not cherry-pick every commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
