rdblue commented on a change in pull request #3457:
URL: https://github.com/apache/iceberg/pull/3457#discussion_r744335891
##########
File path: core/src/main/java/org/apache/iceberg/ReachableFileUtil.java
##########
@@ -114,4 +116,20 @@ private static TableMetadata
findFirstExistentPreviousMetadata(List<MetadataLogE
}
return manifestListLocations;
}
+
+ /**
+ * Returns locations of manifest lists in a table.
+ *
+ * @param table table for which manifestList needs to be fetched
+ * @param snapshotIds snpashots to filter for
+ * @return the location of manifest Lists
+ */
+ public static List<String> manifestListLocations(Table table, Set<Long>
snapshotIds) {
+ Iterable<Snapshot> snapshots = table.snapshots();
+ return StreamSupport.stream(snapshots.spliterator(), false)
Review comment:
Can you add a comment to clarify the `false` argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
