szehon-ho commented on a change in pull request #3457:
URL: https://github.com/apache/iceberg/pull/3457#discussion_r747957457
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseExpireSnapshotsSparkAction.java
##########
@@ -88,7 +95,7 @@ public void accept(String file) {
}
};
- private final Set<Long> expiredSnapshotIds = Sets.newHashSet();
+ private final Set<Long> snapshotIdsToExpire = Sets.newHashSet();
Review comment:
OK, reverted
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseExpireSnapshotsSparkAction.java
##########
@@ -170,13 +177,15 @@ public BaseExpireSnapshotsSparkAction
deleteWith(Consumer<String> newDeleteFunc)
expireSnapshots = expireSnapshots.retainLast(retainLastValue);
}
+ List<Snapshot> expired = expireSnapshots.apply();
+ Set<Long> expiredSnapshotIds =
expired.stream().map(Snapshot::snapshotId).collect(Collectors.toSet());
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
