kbendick opened a new pull request #3520: URL: https://github.com/apache/iceberg/pull/3520
This PR is trying to address this comment: [#3501 (comment)](https://github.com/apache/iceberg/pull/3501#discussion_r745401341) It seems that checkstyle has not been running for some (or all) of the Java / Scala code outside of `java-ci.yml` due to `-Pquick=true`. I had noticed and fixed a rogue checkstyle issue that made it in, but I thought it slipped in during the refactoring of tests as a one time thing. @openinx suggested in this PR: [#3509](https://github.com/apache/iceberg/pull/3509) that we remove the path ignores in java-ci.yaml. But I think that would negate the work of splitting up the tests and the speed built up that we have seen from that. Co-authored-by: huzheng <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
