kbendick commented on pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520#issuecomment-964857295


   The other reason things work presently in `java-ci.yml` is that we have two 
sections related to tests and checks.
   
   We have the one used presently, equivalent to `core-tests`, and then the 
`build-checks` section.
   
   I'm going to add `build-chcks` into the existing code so that nothing gets 
in that doesn't pass CI as it should, and then prioritize a top level workflow 
that orchestrates all of them so when one fails, they all fail.
   
   ```
     core-tests:
       runs-on: ubuntu-latest
       strategy:
         matrix:
           jvm: [8, 11]
       env:
         SPARK_LOCAL_IP: localhost
       steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-java@v1
         with:
           java-version: ${{ matrix.jvm }}
       - uses: actions/cache@v2
         with:
           path: ~/.gradle/caches
           key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
           restore-keys: ${{ runner.os }}-gradle
       - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | 
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
       - run: ./gradlew check -DsparkVersions= -DhiveVersions= -DflinkVersions= 
-Pquick=true -x javadoc
       - uses: actions/upload-artifact@v2
         if: failure()
         with:
           name: test logs
           path: |
             **/build/testlogs
   
     build-checks:
       runs-on: ubuntu-latest
       steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-java@v1
         with:
           java-version: 8
       - run: ./gradlew build -x test -x javadoc -x integrationTest
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to