kbendick commented on a change in pull request #3524: URL: https://github.com/apache/iceberg/pull/3524#discussion_r746967731
########## File path: .github/workflows/flink-ci-workflow.yml ########## @@ -0,0 +1,77 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + + +# Workflow that is intended to be called from the main "CI Orchestrator" +# We do this to ensure that: +# - all workflows that are launched by a PR will fail fast if one of them fails +# - all duplicate workflow runs are cancelled (i.e. only run workflows for the most recent push). +name: "Flink CI Workflow" +on: + workflow_call: Review comment: Essentially I think if we update all of the current main CI workflows to use `on: workflow_call`, and then call them from the orchestrator, we can heavily parallelize and slice and dice tests into various files and still treat them like they were one big run. We'd then have the choice of keeping logic either all in the current files, or moving some of it upwards if we desired. One example reason to move some of it upwards would be to first perform the build in one job the other tests jobs depend on, so they all benefit from the same build cache. But that's a concern for further in the future. For now, just getting the tests to exit early when one fails would be a big win. ########## File path: .github/workflows/hive-ci.yml ########## @@ -19,22 +19,12 @@ name: "Hive CI" on: - push: - paths-ignore: - - '.github/workflows/python-ci.yml' - - '.github/workflows/spark-ci.yml' - - '.github/workflows/flink-ci.yml' - - '.github/workflows/cancel-duplicate-workflow-runs.yml' - - '.gitignore' - - 'dev/**' - - 'arrow/**' - - 'spark/**' - - 'flink/**' - - 'pig/**' - - 'python/**' - - 'python_legacy/**' - - 'site/**' pull_request: + types: + - opened + - reopened + - ready_for_review + - synchronize Review comment: One of the benefits of `synchronize` is that we don't have to duplicate the list of paths to ignore in each workflow file. Currently, we have them both in `on: push` and `on: pull_request`. I might open a separate PR that adds this in earlier just to simplify things. Apparently `on: push` is discouraged for projects that are commonly used as templates for forks anyway. But the main driver is just removing the large block of ignore paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
