kbendick commented on a change in pull request #3524:
URL: https://github.com/apache/iceberg/pull/3524#discussion_r758913710



##########
File path: .github/workflows/hive-ci.yml
##########
@@ -19,22 +19,12 @@
 
 name: "Hive CI"
 on:
-  push:
-    paths-ignore:
-    - '.github/workflows/python-ci.yml'
-    - '.github/workflows/spark-ci.yml'
-    - '.github/workflows/flink-ci.yml'
-    - '.github/workflows/cancel-duplicate-workflow-runs.yml'
-    - '.gitignore'
-    - 'dev/**'
-    - 'arrow/**'
-    - 'spark/**'
-    - 'flink/**'
-    - 'pig/**'
-    - 'python/**'
-    - 'python_legacy/**'
-    - 'site/**'
   pull_request:
+    types:
+      - opened
+      - reopened
+      - ready_for_review
+      - synchronize

Review comment:
       For testing the build _after_ its been merged into master, we want those 
to always go to completion (which they don't).
   
   Currently, this is handled by a mixture of `on: push` and the cancel 
duplicates workflow.
   
   I believe I can fix it so that tests run, to completion, for every single PR 
that gets merged (so they show green or red correctly).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to