RussellSpitzer commented on pull request #3469: URL: https://github.com/apache/iceberg/pull/3469#issuecomment-968921651
This looks fine to me, my only question would be should we be removing all the tests for the deprecated pathway before we remove that code from the codebase. Since the deprecated functions call the new ones it seems like we would be ok keeping them that way? I don't have a strong opinion here though. @aokolnychyi what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
