kbendick commented on a change in pull request #3543: URL: https://github.com/apache/iceberg/pull/3543#discussion_r749702237
########## File path: core/src/test/java/org/apache/iceberg/CachingCatalogTestHelper.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import com.github.benmanes.caffeine.cache.Ticker; +import java.time.Duration; +import java.util.Arrays; +import java.util.List; +import java.util.Locale; +import java.util.Optional; +import java.util.stream.Collectors; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.TableIdentifier; +import org.junit.Assert; + +/** + * Utility class for accessing package-private VisibleForTesting annotated methods + * outside the org.apache.iceberg package. + */ +public class CachingCatalogTestHelper { + + // TODO - Consider making this a delegator? + private CachingCatalogTestHelper() { Review comment: Yeah that's how I had it previously, but the `@VisibleForTesting` annotations caused compilation to fail due to style checking errors. I'll definitely remove this class and then make a subclass like Ryan mentioned. This class came in sort of last minute to get around the compilation failures from using `@VisibleForTesting` and admittedly I do not like this class at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
