rdblue commented on a change in pull request #3543:
URL: https://github.com/apache/iceberg/pull/3543#discussion_r749488471
##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -30,6 +30,14 @@ private CatalogProperties() {
public static final String FILE_IO_IMPL = "io-impl";
public static final String WAREHOUSE_LOCATION = "warehouse";
+ public static final String TABLE_CACHE_ENABLED = "cache-enabled";
+ public static final boolean TABLE_CACHE_ENABLED_DEFAULT = true;
+ public static final String TABLE_CACHE_EXPIRATION_ENABLED =
"cache.expiration-enabled";
+ // Keep as false to maintain backwards compatability. Eventually consider
making true the default.
+ public static final boolean TABLE_CACHE_EXPIRATION_ENABLED_DEFAULT = false;
+ public static final String TABLE_CACHE_EXPIRATION_INTERVAL_MS =
"cache.expiration-interval-ms";
+ public static final long TABLE_CACHE_EXPIRATION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(15);
Review comment:
I agree. 15 minutes is too long. I was thinking more like 30s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
