RussellSpitzer commented on a change in pull request #3387:
URL: https://github.com/apache/iceberg/pull/3387#discussion_r750711241
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -97,27 +97,37 @@ public String name() {
@Override
public RewriteStrategy options(Map<String, String> options) {
- targetFileSize = PropertyUtil.propertyAsLong(options,
- RewriteDataFiles.TARGET_FILE_SIZE_BYTES,
- PropertyUtil.propertyAsLong(
- table().properties(),
- TableProperties.WRITE_TARGET_FILE_SIZE_BYTES,
- TableProperties.WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT));
-
- minFileSize = PropertyUtil.propertyAsLong(options,
- MIN_FILE_SIZE_BYTES,
+ Map<String, String> tableProperties = table().properties();
+
+ targetFileSize = PropertyUtil.resolveLongProperty(
Review comment:
This ends up being pretty difficult to read for me. I wonder if we
should have this similar to the way set up SparkReadConf and SparkWriteConf
options. Maybe ActionConf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
