RussellSpitzer commented on a change in pull request #3387:
URL: https://github.com/apache/iceberg/pull/3387#discussion_r750713928
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -97,27 +97,37 @@ public String name() {
@Override
public RewriteStrategy options(Map<String, String> options) {
- targetFileSize = PropertyUtil.propertyAsLong(options,
- RewriteDataFiles.TARGET_FILE_SIZE_BYTES,
- PropertyUtil.propertyAsLong(
- table().properties(),
- TableProperties.WRITE_TARGET_FILE_SIZE_BYTES,
- TableProperties.WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT));
-
- minFileSize = PropertyUtil.propertyAsLong(options,
- MIN_FILE_SIZE_BYTES,
+ Map<String, String> tableProperties = table().properties();
+
+ targetFileSize = PropertyUtil.resolveLongProperty(
Review comment:
After looking through "PropertyUtil.resolve*" I think It may be much
clearer if we use specified methods like in SparkReadConf and SparkWriteConf,
so this would start with something like ActionsConf(action, table, options) or
what not. And then you would call conf.targetFileSize().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
