RussellSpitzer commented on a change in pull request #3557:
URL: https://github.com/apache/iceberg/pull/3557#discussion_r750719965
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java
##########
@@ -137,4 +165,30 @@ public final ColumnarBatch read(ColumnarBatch reuse, int
numRowsToRead) {
return Pair.of(rowIdMapping, currentRowId);
}
}
+
+ /**
+ * Reuse the row Id mapping array to filter out equality deleted rows.
+ */
+ private void applyEqDelete(ColumnarBatch batch, int[] posDeleteRowIdMapping,
int[] eqDeleteRowIdMapping) {
+ int[] rowIdMapping = posDeleteRowIdMapping == null ? eqDeleteRowIdMapping
: posDeleteRowIdMapping;
Review comment:
It seems like this will only respect one of the two mappings? Or am I
wrong there? In general I would try to avoid functions which only use some
arguments if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
