RussellSpitzer commented on a change in pull request #3557:
URL: https://github.com/apache/iceberg/pull/3557#discussion_r750721112
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java
##########
@@ -96,9 +94,39 @@ public final ColumnarBatch read(ColumnarBatch reuse, int
numRowsToRead) {
Integer numRows = rowIdMapping.second();
batch.setNumRows(numRows);
}
+
+ if (deletes != null && deletes.hasEqDeletes()) {
+ applyEqDelete(batch, rowIdMapping == null ? null : rowIdMapping.first(),
eqDeleteRowIdMapping);
Review comment:
I would probably try to extract out the logic for choosing which row
mapping to use from "applyEqDelete" and do it here instead so it's simpler to
read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
