xloya commented on a change in pull request #3563:
URL: https://github.com/apache/iceberg/pull/3563#discussion_r751875077
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
##########
@@ -327,6 +328,7 @@ private Result
doExecuteWithPartialProgress(RewriteExecutionContext ctx, Stream<
LOG.error("{} is true but no rewrite commits succeeded. Check the logs
to determine why the individual " +
"commits failed. If this is persistent it may help to increase {}
which will break the rewrite operation " +
"into smaller commits.", PARTIAL_PROGRESS_ENABLED,
PARTIAL_PROGRESS_MAX_COMMITS);
+ throw new NoCommitSucceedException("No rewrite commits succeeded after
max commits");
Review comment:
@rdblue I see that we have plans to rewrite delete files, if we support
partial commit for rewrite delete files, it also will have a no-commit-succeed
scenario. So i think maybe it makes sense to create a new exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
