xloya commented on a change in pull request #3563:
URL: https://github.com/apache/iceberg/pull/3563#discussion_r752918062
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -88,6 +89,15 @@
String USE_STARTING_SEQUENCE_NUMBER = "use-starting-sequence-number";
boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true;
+ /**
+ * If we make {@link #PARTIAL_PROGRESS_ENABLED} to be true, for some
reasons, the all commits may not be successful
+ * in the end. If we do rewrite in an isolated job, wo may want to fail the
entire job. But if we do rewrite after
+ * writing, may not want to fail the entire job. This setting determines
whether the entire rewrite process will fail
+ * if no commits succeeded in the end. This setting has no effect if partial
progress is disabled.
+ */
+ String IGNORE_NO_SUCCESSFUL_COMMIT_ENABLED =
"ignore-no-successful-commit.enabled";
Review comment:
Sounds great! I will add a prefix name of the setting, but according to
what @RussellSpitzer said above, it may not be able to use
`all-commits-failed`, it may just be `no-commit-succeed` because the definition
of `commit-failed` may be a metadata operation in our project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
