flyrain edited a comment on pull request #3572: URL: https://github.com/apache/iceberg/pull/3572#issuecomment-972560879
I think it makes sense to close `vec` in class `VectorizedArrowReader`. `vec` is a private filed and initialized inside the class, for example, here, https://github.com/apache/iceberg/blob/d6cbca0c2fb3d10083b304bcbdf16bf51e3b586b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java#L304 We should close it inside the class as well. Instead of removing the close logic in class `VectorizedArrowReader`, I'd recommend to use `reader::close` instead of `vectorHolders::close` in the method `BaseBatchReader::closeVectors` https://github.com/apache/iceberg/blob/d6cbca0c2fb3d10083b304bcbdf16bf51e3b586b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/BaseBatchReader.java#L55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
