flyrain commented on pull request #3572: URL: https://github.com/apache/iceberg/pull/3572#issuecomment-973118840
> @flyrain, I think `close` in `VectorizedArrowReader` should be used to release any file-related resources instead of the memory. For example, when reuse is disabled, we should be able to close vectors but not the readers. In that sense, I'd recommend to have another method(e.g. `closeVectors`)to close all vec inside the VectorizedArrowReader other than `VectorizedArrowReader::close`, which is supposed to close the reader itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
