nastra commented on a change in pull request #3257:
URL: https://github.com/apache/iceberg/pull/3257#discussion_r752004580
##########
File path:
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
##########
@@ -184,13 +184,17 @@ protected void refreshFromMetadataLocation(String
newLocation, Predicate<Excepti
"Table UUID does not match: current=%s != refreshed=%s",
currentMetadata.uuid(), newUUID);
}
- this.currentMetadata = newMetadata.get();
+ this.currentMetadata = validateRefreshedMetadata(newMetadata.get());
this.currentMetadataLocation = newLocation;
this.version = parseVersion(newLocation);
}
this.shouldRefresh = false;
}
+ protected TableMetadata validateRefreshedMetadata(TableMetadata metadata) {
Review comment:
that would require making a bunch of fields `protected` in the base
class. I renamed the method to `maybeValidateAndUpdateMetadata`. Hopefully that
makes its purpose clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
