nastra commented on a change in pull request #3257:
URL: https://github.com/apache/iceberg/pull/3257#discussion_r752012394
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -717,6 +717,19 @@ public TableMetadata removeSnapshotLogEntries(Set<Long>
snapshotIds) {
snapshots, newSnapshotLog, addPreviousFile(file, lastUpdatedMillis));
}
+ public TableMetadata withUpdatedSnapshotAndSchema(long snapshotId, int
schemaId, int sortOrderId, int specId) {
Review comment:
I think that things would be easier with the changes from
https://github.com/apache/iceberg/pull/2957, where we could just call the
builder and only update the actual fields that we need. Then we wouldn't need
to have the `withUpdatedSnapshotAndSchema` method in `TableMetadata` and could
do everything in the `NessieCatalog` where we need it. Maybe we should go
forward with this as is right now and then refactor/improve this once #2957 is
merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
