aokolnychyi commented on a change in pull request #3600:
URL: https://github.com/apache/iceberg/pull/3600#discussion_r759574930
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -170,16 +172,13 @@ void delete(CharSequence path) {
return ImmutableList.of();
}
- // use a common metrics evaluator for all manifests because it is bound to
the table schema
- StrictMetricsEvaluator metricsEvaluator = new
StrictMetricsEvaluator(tableSchema, deleteExpression);
Review comment:
I can no longer use one metrics evaluator so I switched to one per
manifest with some caching. I can introduce more caching per spec to avoid
creating one expression evaluator per manifest but it will probably complicate
things a little. Let me know what everybody thinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
