aokolnychyi commented on a change in pull request #3600:
URL: https://github.com/apache/iceberg/pull/3600#discussion_r759670804
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -429,13 +425,44 @@ private ManifestFile filterManifestWithDeletedFiles(
}
}
- private Evaluator strictDeleteEvaluator(PartitionSpec spec) {
- Expression strictExpr = Projections.strict(spec).project(deleteExpression);
- return new Evaluator(spec.partitionType(), strictExpr);
- }
+ // an evaluator that checks whether rows in a file may/must match a given
expression
+ // this class first partially evaluates the provided expression using the
partition tuple
+ // and then checks the remaining part of the expression using metrics
evaluators
+ private class ExpressionEvaluator {
Review comment:
Sounds good. It is an internal class so I did not worry about it. Do we
want to keep it as a private inner class? The logic seems generic enough so
that we can make move it into a top-level class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
