rajarshisarkar commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r764707554
##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -101,6 +101,42 @@ public static Snapshot oldestAncestor(Table table) {
return ancestorsOf(start, lookup);
}
+ /**
+ * Traverses the history of the table's current snapshot
Review comment:
I have taken the idea from @rdblue's code and have named the method
`oldestAncestorFrom`.
Please let me know if we are planning to call `oldestAncestor` if
`oldestAncestorFrom` fails to find the oldest snapshot (instead of throwing an
exception).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
