nastra commented on a change in pull request #3688:
URL: https://github.com/apache/iceberg/pull/3688#discussion_r764766940
##########
File path: api/src/main/java/org/apache/iceberg/catalog/Namespace.java
##########
@@ -19,19 +19,19 @@
package org.apache.iceberg.catalog;
-import java.util.Arrays;
import org.apache.iceberg.relocated.com.google.common.base.Joiner;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.immutables.value.Value;
/**
* A namespace in a {@link Catalog}.
*/
-public class Namespace {
- private static final Namespace EMPTY_NAMESPACE = new Namespace(new String[]
{});
[email protected]
+public abstract class Namespace {
Review comment:
JSON serde can be done as shown below once #3424 would need this:
```
@JsonSerialize(as = ImmutableNamespace.class)
@JsonDeserialize(as = ImmutableNamespace.class)
```
The same applies for `TableIdentifier`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
