nastra commented on a change in pull request #3688:
URL: https://github.com/apache/iceberg/pull/3688#discussion_r764840556
##########
File path: api/src/test/java/org/apache/iceberg/catalog/TestTableIdentifier.java
##########
@@ -60,11 +60,11 @@ public void testToLowerCase() {
public void testInvalidTableName() {
Assertions.assertThatThrownBy(() -> TableIdentifier.of(Namespace.empty(),
""))
.isInstanceOf(IllegalArgumentException.class)
- .hasMessage("Invalid table name: null or empty");
+ .hasMessage("Invalid table name: empty");
Assertions.assertThatThrownBy(() -> TableIdentifier.of(Namespace.empty(),
null))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("Invalid table name: null or empty");
+ .isInstanceOf(NullPointerException.class)
Review comment:
alternatively, we could add `@Value.Style(throwForNullPointer =
IllegalArgumentException.class)` to throw an IAE for nulls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
