openinx commented on a change in pull request #3687:
URL: https://github.com/apache/iceberg/pull/3687#discussion_r765366846
##########
File path:
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/TestLocalAliyunOSS.java
##########
@@ -69,6 +70,9 @@ public void after() {
@Test
public void testBuckets() {
+ Assume.assumeTrue("Aliyun integration test cannot delete existing bucket
from test environment.",
+ OSS_TEST_RULE.getClass() == AliyunOSSMockRule.class);
Review comment:
> In AWS we just assumes the bucket exists, and create a random prefix
as the root for all tests.
The aliyun integration tests is using the same approach as you said. This
suite case was designed to guarantee that the Aliyun Mock OSS Application will
have the same semantics as the production aliyun OSS services. If both
AliyunOSSMockRule and OSSIntegrationTestRule are successfully applied to this
case, then we can ensure that all the unit tests which are built on top of the
AliyunOSSMockRule are correctly designed.
As we iceberg FileIO won't depend any bucket creation or deletion interfaces
, plus the dangerous bucket deletion behavior. So Here I disabled the buckets
tests for integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
