kbendick commented on a change in pull request #3543: URL: https://github.com/apache/iceberg/pull/3543#discussion_r767196258
########## File path: spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalogCacheExpiration.java ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.source; + +import java.util.Map; +import org.apache.iceberg.CachingCatalog; +import org.apache.iceberg.CatalogProperties; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.spark.SparkCatalog; +import org.apache.iceberg.spark.SparkCatalogTestBase; +import org.apache.spark.sql.connector.catalog.TableCatalog; +import org.assertj.core.api.Assertions; +import org.junit.Test; +import org.junit.runners.Parameterized; + +public class TestSparkCatalogCacheExpiration extends SparkCatalogTestBase { Review comment: So there are now 4 tests. There are a lot of possible combinations to test, let me know which ones you think I should remove. 1. TestSparkCatalogCacheExpirationDisabled 1a. Checks that CachingCatalog is not used when cache.expiration-interval-millis=0 (this one seems important). 2. TestSparkCatalogCacheExpirationEnabled 2a. Check with cache-enabled and expiration enabled via 30s (in millis) 2b. Check with cache-enabled and expiration disabled via `-1` 3. TestSparkSessionCatalogCacheExpiration 3a. Same as 2a, but using the SparkSessionCatalog I think that 1a is important to have a test that verifies that behavior, same with 2b. If we wanted to get rid of a test, I would vote for 2a and just use 3a instead (since that tests the same behavior but ALSO ensures that the SparkSessionCatalog works with the new configs as well). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
