kbendick commented on a change in pull request #3543: URL: https://github.com/apache/iceberg/pull/3543#discussion_r767197063
########## File path: spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalogCacheExpiration.java ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.source; + +import java.util.Map; +import org.apache.iceberg.CachingCatalog; +import org.apache.iceberg.CatalogProperties; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.spark.SparkCatalog; +import org.apache.iceberg.spark.SparkCatalogTestBase; +import org.apache.spark.sql.connector.catalog.TableCatalog; +import org.assertj.core.api.Assertions; +import org.junit.Test; +import org.junit.runners.Parameterized; + +public class TestSparkCatalogCacheExpiration extends SparkCatalogTestBase { Review comment: The reason that we need to setup different Spark catalogs to test this is that the configuration that gets passed into `initialize`, so a second behavior test can't be run over the same catalog. Again, let me know which tests to remove. And when I backport it, I'll only backport a subset of the tests if we leave multiple in this one. But I think at least 2 of these are necessary checks (`cache.expiration-interval-millis=0` disabling caching entirely and `cache.expiration-interval-millis=-1` for cache forever). Ideally we'd leave 3 but I understand these Spark tests are expensive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
