rdblue commented on a change in pull request #3663:
URL: https://github.com/apache/iceberg/pull/3663#discussion_r767313428
##########
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##########
@@ -63,15 +64,17 @@
private final Configuration conf;
private final Path location;
private final FileIO fileIO;
+ private final LockManager lockManager;
private volatile TableMetadata currentMetadata = null;
private volatile Integer version = null;
private volatile boolean shouldRefresh = true;
- protected HadoopTableOperations(Path location, FileIO fileIO, Configuration
conf) {
+ protected HadoopTableOperations(Path location, FileIO fileIO, Configuration
conf, LockManager lockMgr) {
this.conf = conf;
this.location = location;
this.fileIO = fileIO;
+ this.lockManager = lockMgr;
Review comment:
In Iceberg, we avoid abbreviations like `manager -> mgr` because it
hurts readability and isn't actually easier to type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
