rdblue commented on a change in pull request #3663:
URL: https://github.com/apache/iceberg/pull/3663#discussion_r767313634
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/glue/TestDynamoLockManager.java
##########
@@ -153,9 +153,9 @@ public void testAcquireSingleProcess() throws Exception {
@Test
public void testAcquireMultiProcessAllSucceed() throws Exception {
lockManager.initialize(ImmutableMap.of(
- CatalogProperties.LOCK_ACQUIRE_INTERVAL_MS, "500",
- CatalogProperties.LOCK_ACQUIRE_TIMEOUT_MS, "100000000",
- CatalogProperties.LOCK_TABLE, lockTableName
+ LockManagerProperties.LOCK_ACQUIRE_INTERVAL_MS, "500",
+ LockManagerProperties.LOCK_ACQUIRE_TIMEOUT_MS, "100000000",
+ LockManagerProperties.LOCK_TABLE, lockTableName
Review comment:
I don't think these properties need to be relocated. They are still
properties that are passed to the catalog, so we should leave them in
`CatalogProperties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
