RussellSpitzer commented on a change in pull request #3724:
URL: https://github.com/apache/iceberg/pull/3724#discussion_r767773607
##########
File path:
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java
##########
@@ -79,11 +83,34 @@ public void commitFileGroups(Set<RewriteFileGroup>
fileGroups) {
}
RewriteFiles rewrite =
table.newRewrite().validateFromSnapshot(startingSnapshotId);
- if (useStartingSequenceNumber) {
- long sequenceNumber =
table.snapshot(startingSnapshotId).sequenceNumber();
- rewrite.rewriteFiles(rewrittenDataFiles, addedDataFiles, sequenceNumber);
+
+ if (addedDataFiles.size() > 0) {
Review comment:
I'm not sure why we are making the changes here, shouldn't we just be
removing the precondition check
https://github.com/apache/iceberg/blob/f5a753791f4dc6aca78569a14f731feda9edf462/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/FileRewriteCoordinator.java#L58
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
