jackye1995 commented on a change in pull request #3724:
URL: https://github.com/apache/iceberg/pull/3724#discussion_r768102963
##########
File path:
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java
##########
@@ -79,11 +83,34 @@ public void commitFileGroups(Set<RewriteFileGroup>
fileGroups) {
}
RewriteFiles rewrite =
table.newRewrite().validateFromSnapshot(startingSnapshotId);
- if (useStartingSequenceNumber) {
- long sequenceNumber =
table.snapshot(startingSnapshotId).sequenceNumber();
- rewrite.rewriteFiles(rewrittenDataFiles, addedDataFiles, sequenceNumber);
+
+ if (addedDataFiles.size() > 0) {
Review comment:
yeah, I was gonna ask the same question. The original logic was
implemented before v2 deletes, so I think it make sense to now to just remove
that restriction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
