rdblue commented on a change in pull request #3722:
URL: https://github.com/apache/iceberg/pull/3722#discussion_r768098662
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -286,4 +287,35 @@ public int hashCode() {
// use only name in order to correctly invalidate Spark cache
return icebergTable.name().hashCode();
}
+
+ private CaseInsensitiveStringMap addSnapshotId(CaseInsensitiveStringMap
options) {
Review comment:
I think this should match the version from #3269:
https://github.com/apache/iceberg/pull/3269/files#diff-31cb389fec0f0d8d4bc9ae93b6ed7624aaefb064adecde1da37ebcf8ecf748acR287-R300
There is no need to access all of the state information here. This method's
responsibility is to create a new `options` map with the correct snapshot, not
to decide what happens in the scan builder.
The snapshot ID to scan should be resolved in the caller, `newScanBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
