rdblue commented on a change in pull request #3722:
URL: https://github.com/apache/iceberg/pull/3722#discussion_r768102151
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -186,22 +185,24 @@ public ScanBuilder
newScanBuilder(CaseInsensitiveStringMap options) {
icebergTable.refresh();
}
- SparkScanBuilder scanBuilder = new SparkScanBuilder(sparkSession(),
icebergTable, options);
-
- if (requestedSchema != null) {
- scanBuilder.pruneColumns(requestedSchema);
- }
-
- return scanBuilder;
+ return new SparkScanBuilder(sparkSession(), icebergTable,
addSnapshotId(options));
Review comment:
I think this method needs to determine the base schema (whatever was
returned by `schema()`) and pass that into the scan builder so that the scan is
consistent with analysis that's already happened using just the table instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
