[GitHub] [iceberg] kbendick commented on a change in pull request #3543: Add configurable cache expiry to caching catalog

Mon, 13 Dec 2021 16:14:07 -0800 


kbendick commented on a change in pull request #3543:
URL: https://github.com/apache/iceberg/pull/3543#discussion_r768216235



##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -30,6 +30,21 @@ private CatalogProperties() {
   public static final String FILE_IO_IMPL = "io-impl";
   public static final String WAREHOUSE_LOCATION = "warehouse";
 
+  public static final String CACHE_ENABLED = "cache-enabled";
+  public static final boolean CACHE_ENABLED_DEFAULT = true;
+
+  /**
+   * Behavior of specific values of cache.expiration-interval-ms
+   * <ul>

Review comment:
       You mean a newline before the unordered list tag?
   
   I don't think this needs <p>. Here's the docs generated without it.
   
   
![image](https://user-images.githubusercontent.com/9833362/145909382-7f39dd5e-a28c-42de-802c-d659c0c68efc.png)
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to