RussellSpitzer commented on a change in pull request #3733:
URL: https://github.com/apache/iceberg/pull/3733#discussion_r768308343
##########
File path: core/src/test/java/org/apache/iceberg/TestTables.java
##########
@@ -103,6 +104,11 @@ public static TestTable load(File temp, String name) {
return new TestTable(ops, name);
}
+ public static TestTable load(File temp, String name, BiFunction<File,
String, TestTableOperations> opsSupplier) {
Review comment:
Since we only have one usage of this function, maybe instead of
providing the fully extensible version here we provide a method like
```java
public static TestTable tableWithCommitStateUnknown(File temp, String name) {
commitStateUnknownOperations = new TestTables.TestTableOperations(name,
file) {
@Override
public void commit(TableMetadata base, TableMetadata
updatedMetadata) {
super.commit(base, updatedMetadata);
throw new CommitStateUnknownException(new
RuntimeException(errorMsg));
}
return new testTable(commitStateUnknownOperations, name)
}
```
Just since we aren't really using the BiFunction for anything but injecting
this particular operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
