RussellSpitzer commented on a change in pull request #3733:
URL: https://github.com/apache/iceberg/pull/3733#discussion_r768309001



##########
File path: core/src/test/java/org/apache/iceberg/TestTransaction.java
##########
@@ -699,4 +701,38 @@ public void 
testTransactionRewriteManifestsAppendedDirectly() throws IOException
 
     Assert.assertFalse("Append manifest should be deleted on expiry", new 
File(newManifest.path()).exists());
   }
+
+  @Test
+  public void testTransactionNotDeletingMetadataOnUnknownSate() throws 
IOException {

Review comment:
       Should we add tests for the other changed code paths? I notice we handle 
this in Create,Replace and CreateOrReplace as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to