marton-bod commented on a change in pull request #3752:
URL: https://github.com/apache/iceberg/pull/3752#discussion_r770431382
##########
File path: core/src/main/java/org/apache/iceberg/SerializableTable.java
##########
@@ -107,7 +108,13 @@ private String metadataFileLocation(Table table) {
private FileIO fileIO(Table table) {
if (table.io() instanceof HadoopConfigurable) {
- ((HadoopConfigurable) table.io()).serializeConfWith(conf -> new
SerializableConfiguration(conf)::get);
+ HadoopConfigurable configurableIo = (HadoopConfigurable) table.io();
+ if
("true".equalsIgnoreCase(configurableIo.getConf().get(ConfigProperties.CONFIG_SERIALIZATION_DISABLED)))
{
+ // serialize with an empty Configuration object - configs should be
populated on the deserializer-side
+ configurableIo.serializeConfWith(conf -> new
SerializableConfiguration(new Configuration(false))::get);
Review comment:
Good point. Created a new implementation for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
