marton-bod commented on a change in pull request #3752:
URL: https://github.com/apache/iceberg/pull/3752#discussion_r770696281
##########
File path: core/src/main/java/org/apache/iceberg/SerializableTable.java
##########
@@ -386,4 +393,20 @@ public Configuration get() {
return conf;
}
}
+
+ private static class EmptySerializedConfiguration implements Serializable {
+
+ private transient volatile Configuration conf = null;
+
+ public Configuration get() {
+ if (conf == null) {
+ synchronized (this) {
Review comment:
No, that's a good point, it should throw an exception. This `get()`
method was mistakenly accessed during split generation part, where the manifest
files are being read even though the config has already been removed earlier by
calling the `SerializableTable.copyOf(table)` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
