rdblue commented on a change in pull request #3764:
URL: https://github.com/apache/iceberg/pull/3764#discussion_r772003153
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java
##########
@@ -199,6 +203,20 @@ public DistributionMode
copyOnWriteDeleteDistributionMode() {
}
}
+ public DistributionMode copyOnWriteUpdateDistributionMode() {
+ String updateModeName = confParser.stringConf()
+ .option(SparkWriteOptions.DISTRIBUTION_MODE)
+ .tableProperty(TableProperties.UPDATE_DISTRIBUTION_MODE)
+ .parseOptional();
+
+ if (updateModeName != null) {
+ DistributionMode updateMode = DistributionMode.fromName(updateModeName);
+ return adjustWriteDistributionMode(updateMode);
Review comment:
As with the copy-on-write delete case, I think I'd prefer to preserve
the existing file boundaries and row order if the table is unpartitioned and
unsorted. I would also do that as the default, if neither the write order or
the update order is specified for unpartitioned tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
