rdblue commented on a change in pull request #3763:
URL: https://github.com/apache/iceberg/pull/3763#discussion_r772009258
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -291,17 +247,14 @@ public boolean equals(Object o) {
readSchema().equals(that.readSchema()) && // compare Spark schemas to
ignore field ids
filterExpressions().toString().equals(that.filterExpressions().toString()) &&
runtimeFilterExpressions.toString().equals(that.runtimeFilterExpressions.toString())
&&
- Objects.equals(snapshotId, that.snapshotId) &&
- Objects.equals(startSnapshotId, that.startSnapshotId) &&
- Objects.equals(endSnapshotId, that.endSnapshotId) &&
- Objects.equals(asOfTimestamp, that.asOfTimestamp);
+ ctx.equals(that.ctx);
}
@Override
public int hashCode() {
return Objects.hash(
- table().name(), readSchema(), filterExpressions().toString(),
runtimeFilterExpressions.toString(),
- snapshotId, startSnapshotId, endSnapshotId, asOfTimestamp);
+ table().name(), readSchema(), filterExpressions().toString(),
+ runtimeFilterExpressions.toString(), ctx);
Review comment:
Looks like `runtimeFilterExpressions.toString()` didn't need to move,
which would keep the previous line from changing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
