rdblue commented on a change in pull request #3763:
URL: https://github.com/apache/iceberg/pull/3763#discussion_r772009644
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -310,4 +263,62 @@ public String toString() {
"IcebergScan(table=%s, type=%s, filters=%s, runtimeFilters=%s,
caseSensitive=%s)",
table(), expectedSchema().asStruct(), filterExpressions(),
runtimeFilterExpressions, caseSensitive());
}
+
+ static class Context {
Review comment:
Looks like this comes entirely from `SparkReadConf`, which is also
passed into `SparkBatchQueryScan`. Instead of creating the context and passing
it in, why not create it in this class? But then, if it is only used in this
class, why not leave `equals` and `hashCode` unchanged and not use this at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
