pvary commented on a change in pull request #3752:
URL: https://github.com/apache/iceberg/pull/3752#discussion_r772887138
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -244,4 +283,21 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
// this is an exception to the interface documentation, but it's a safe
operation to add this property
props.put(InputFormatConfig.TABLE_SCHEMA, schemaJson);
}
+
+ private static class NonSerializingConfig implements Serializable {
+
+ private transient volatile Configuration conf;
Review comment:
Do we set the config from multiple threads?
Do we set the config at all?
I think this could be `final` instead of `volatile`, as we so not set the
conf, we create a new `NonSerializingConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
