ajantha-bhat commented on a change in pull request #3745:
URL: https://github.com/apache/iceberg/pull/3745#discussion_r774568666
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -781,10 +801,29 @@ public static TableIdentifier
identifierToTableIdentifier(Identifier identifier)
Object value =
CatalystTypeConverters.convertToScala(catalystValue, field.dataType());
values.put(field.name(), String.valueOf(value));
});
- return new SparkPartition(values, partition.path().toString(),
format);
+ FileStatus fileStatus =
+
scala.collection.JavaConverters.seqAsJavaListConverter(partition.files()).asJava().get(0);
+
+ return new SparkPartition(values,
fileStatus.getPath().getParent().toString(), format);
}).collect(Collectors.toList());
}
+ private static List<org.apache.spark.sql.catalyst.expressions.Expression>
getPartitionFilterExpressions(
+ SparkSession spark, String tableName, Map<String, String>
partitionFilter) {
+ List<org.apache.spark.sql.catalyst.expressions.Expression>
filterExpressions = Lists.newArrayList();
+ for (Map.Entry<String, String> entry : partitionFilter.entrySet()) {
+ String filter = entry.getKey() + " = '" + entry.getValue() + "'";
Review comment:
why do we have quotes ('') for the value?
Example: If `id` is an integer column, then we need `id = 3` in the query
instead of `id ='3'` ?
have we tested both string and non string partition columns ?
I was also thinking instead of map, can we expose the `where` clause in the
call procedure (similar to rewrite_data files), so user can give filters other
than equals also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
