kbendick commented on a change in pull request #3745:
URL: https://github.com/apache/iceberg/pull/3745#discussion_r779808904
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java
##########
@@ -172,11 +173,7 @@ private void importFileTable(Table table, Path
tableLocation, String format, Map
} else {
Preconditions.checkArgument(!partitions.isEmpty(),
"Cannot find any partitions in table %s", partitions);
Review comment:
Nit / corner case:
Should we update the precondition message to indicate that it's possible
that the filter didn't match any partitions? The current error message now
might be kind of confusing to users if the file based table is partitioned.
Maybe just `Cannot find any matching partitions in table %s`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
