kbendick commented on a change in pull request #3801:
URL: https://github.com/apache/iceberg/pull/3801#discussion_r775763070
##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -105,14 +94,14 @@ public void delete(TableIdentifier tableIdentifier, Table
table, RemovalCause ca
}
private Cache<TableIdentifier, Table> createTableCache(Ticker ticker) {
- Caffeine<TableIdentifier, Table> cacheBuilder = Caffeine
+ Caffeine<Object, Object> cacheBuilder = Caffeine
Review comment:
So technically it works if you put the types, but intellij does kind of
freak out (even if you put the types on the right side and the left).
This is normal, to use `<Object, Object>` until something gives it type
definitions (after which there are strict rules about using that chained fluent
builder because it stores type info from the responseListener, which doesn't
come until later now).
Starting with `<Object, Object>` is very normal with Caffeine's builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
