kbendick commented on a change in pull request #3801:
URL: https://github.com/apache/iceberg/pull/3801#discussion_r775768849
##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -86,16 +82,13 @@ protected CachingCatalog(Catalog catalog, boolean
caseSensitive, long expiration
}
/**
- * CacheWriter class for removing metadata tables when their associated data
table is expired
+ * RemovalListener class for removing metadata tables when their associated
data table is expired
* via cache expiration.
*/
- class MetadataTableInvalidatingCacheWriter implements
CacheWriter<TableIdentifier, Table> {
- @Override
- public void write(TableIdentifier tableIdentifier, Table table) {
- }
-
+ class MetadataTableInvalidatingRemovalListener implements
RemovalListener<TableIdentifier, Table> {
@Override
- public void delete(TableIdentifier tableIdentifier, Table table,
RemovalCause cause) {
+ public void onRemoval(TableIdentifier tableIdentifier, Table table,
RemovalCause cause) {
+ LOG.debug("Evicted {} from the table cache ({})", tableIdentifier,
cause);
Review comment:
Given that this inner class is the only thing that uses the Logger,
should we make the call to LoggerFactory.getLogger here instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
