hililiwei commented on a change in pull request #3810:
URL: https://github.com/apache/iceberg/pull/3810#discussion_r775802176
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORC.java
##########
@@ -145,6 +146,7 @@ public WriteBuilder metricsConfig(MetricsConfig
newMetricsConfig) {
public <D> FileAppender<D> build() {
Preconditions.checkNotNull(schema, "Schema is required");
+ parseWriterCustomizedConf(conf);
Review comment:
@jackye1995 Would it be more reasonable to add a common method to
resolve all configuration items, converting the specific name in Iceberg to the
native name of orc? In this way, users can use all orc configuration items, not
only those listed in properties.
The method may like this:
```
private void setAllOrcConf(Configuration conf) {
Arrays.stream(OrcConf.values()).forEach(oneConf -> {
String attribute = oneConf.getAttribute();
String icebergPropertiesName =
("write." + attribute).replace(".", "-")
.replaceFirst("-", ".")
.replaceFirst("-", ".");
if (conf.get(icebergPropertiesName) != null) {
conf.set(attribute, conf.get(icebergPropertiesName);
}
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
