pvary commented on pull request #3810: URL: https://github.com/apache/iceberg/pull/3810#issuecomment-1004025741
I think if we decide that we need the default configuration values set for Iceberg reads, then we should do this the same way as it has been done with the other file formats: - Parquet: https://github.com/apache/iceberg/blob/129cdfafdedb3df157fe925023ce4741dba93986/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java#L304-L320 - Avro: https://github.com/apache/iceberg/blob/303f92547c344146a3ea500e315c285fa446d7b2/core/src/main/java/org/apache/iceberg/avro/Avro.java#L208-L213 Basically we should create a Context object for the ORC as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
