rdblue commented on a change in pull request #3817:
URL: https://github.com/apache/iceberg/pull/3817#discussion_r776882400
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java
##########
@@ -77,13 +79,13 @@ public BaseStatistics getStatistics(BaseStatistics
cachedStatistics) {
tableLoader.open();
try (TableLoader loader = tableLoader) {
Table table = loader.loadTable();
- return FlinkSplitGenerator.createInputSplits(table, context);
+ return FlinkSplitGenerator.createInputSplits(table, context,
localityPreferred);
}
}
@Override
public InputSplitAssigner getInputSplitAssigner(FlinkInputSplit[]
inputSplits) {
- return new DefaultInputSplitAssigner(inputSplits);
+ return new LocatableInputSplitAssigner(inputSplits);
Review comment:
Shouldn't this check `localityPreferred` and return a
`DefaultInputSplitAssigner` if it is false? That way we get the same behavior
for all file stores other than HDFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
